AnandInguva commented on code in PR #29360:
URL: https://github.com/apache/beam/pull/29360#discussion_r1398304853
##########
sdks/python/apache_beam/io/gcp/gcsfilesystem.py:
##########
@@ -352,27 +352,20 @@ def delete(self, paths):
Args:
Review Comment:
Yes, the matching part. When a directory is provided, we append `*`.
* expected - all the dirs and objects should be deleted.
* Actual - only objects are getting deleted.
Solution - let's use `bucket.list_buckets()` and match the path with the
provided dirs and delete them. I can spin up a PR if this sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
