johannaojeling commented on issue #21388: URL: https://github.com/apache/beam/issues/21388#issuecomment-1819509064
Thanks for offering to help @knabeel77! As @damccorm mentions, Codecov will show where coverage is low. As an example, a good place to start may be writing unit tests for [findDisplayDataType](https://github.com/apache/beam/blob/3439d6ab25934d390401b49f123617187fdcd318/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go#L172) invoked by [newDisplayData](https://github.com/apache/beam/blob/3439d6ab25934d390401b49f123617187fdcd318/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go#L185), which both lack coverage and don't rely on any external dependencies? There are some nice table-driven tests in [job_test.go](https://github.com/apache/beam/blob/3439d6ab25934d390401b49f123617187fdcd318/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job_test.go) in the same directory that you could take inspiration from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
