damondouglas commented on code in PR #29401:
URL: https://github.com/apache/beam/pull/29401#discussion_r1398681250
##########
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/RedisClient.java:
##########
@@ -61,6 +62,15 @@ long decr(String key) throws UserCodeExecutionException {
}
}
+ /** Get a byte array associated with a byte array key. Returns null if key
does not exist. */
+ byte @Nullable [] getBytes(byte[] key) throws UserCodeExecutionException {
Review Comment:
It's actually important to return a nullable byte array instead of an empty
one as this follows the underlying Redis client. The checker complained with
what I personally think is the more readable `@Nullable byte[]` and for some
reason preferred `byte @Nullable []`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
