damccorm commented on code in PR #29480:
URL: https://github.com/apache/beam/pull/29480#discussion_r1402662019
##########
.github/workflows/java_tests.yml:
##########
@@ -89,7 +89,7 @@ jobs:
run: rm ~/.m2/settings.xml
# :sdks:java:core:test
- name: Run :sdks:java:core:test
- uses: ./.github/actions/gradle-command-action
+ uses: gradle/gradle-build-action@v2
Review Comment:
I'm all for getting rid of our submodule actions, its not a great pattern at
this point. Thanks for doing this!
With that said, is there any advantage of using this instead of the current
composite workflow with gradle-command-self-hosted-action? I like that because
(a) it gives us a single place to apply some arguments we always want on in CI,
(b) we can do any other setup there like removing settings.xml, and (c) its
what the rest of our workflows are already standardized on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
