damondouglas commented on PR #29486: URL: https://github.com/apache/beam/pull/29486#issuecomment-1828375901
> This looks valid to me. > > Just a note - this kind of clean up some times is not as trivial as one thought, and could introduce bugs. Recently I dealt with #29393 which was introduced in nullness clean up and took two other attempt to fix it Thank you, @Abacn. This is why I'm going a class at a time and extremely slowly. Additionally, I only perform one PR at a time as well and let it merge and wait for some time to see if this introduced new problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
