damccorm commented on code in PR #29549: URL: https://github.com/apache/beam/pull/29549#discussion_r1409499314
########## .github/workflows/README.md: ########## @@ -271,7 +271,6 @@ Please note that jobs with matrix need to have matrix element in the comment. Ex | Workflow name | Matrix | Trigger Phrase | Cron Status | |:-------------:|:------:|:--------------:|:-----------:| -| [ PostCommit BeamMetrics Publish ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml) | N/A |`Run Beam Metrics Deployment`| [](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml?query=event%3Aschedule) | [ PostCommit Go ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml) | N/A |`Run Go PostCommit`| [](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml?query=event%3Aschedule) | Review Comment: We need to also update all the postcommits in this file to not have trigger phrases listed. Ideally we'd list the file to modify instead. We should also modify the part that talks about trigger phrases at the top and explain this approach. ########## .github/workflows/beam_Java_JMH.yml: ########## @@ -19,7 +19,7 @@ on: schedule: - cron: '0 0 * * 0' pull_request_target: - paths: ['release/trigger_all_tests.json'] + paths: ['release/trigger_all_tests.json', 'beam_Java_JMH.json'] Review Comment: Our guidance could even be to check them in, it does no harm. ########## .github/workflows/beam_Java_JMH.yml: ########## @@ -19,7 +19,7 @@ on: schedule: - cron: '0 0 * * 0' pull_request_target: - paths: ['release/trigger_all_tests.json'] + paths: ['release/trigger_all_tests.json', 'beam_Java_JMH.json'] Review Comment: Can we put these in a subfolder? Maybe `.github/trigger_files`? That way if they accidentally get checked in it doesn't cause issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
