AnandInguva commented on code in PR #29542:
URL: https://github.com/apache/beam/pull/29542#discussion_r1412841874


##########
sdks/python/apache_beam/ml/transforms/handlers.py:
##########
@@ -201,6 +198,8 @@ class MergeDicts(beam.DoFn):
   def process(self, element):
     _, element = element
     new_dict = {}
+    # Assertion could fail due to UUID collision.

Review Comment:
   There will be two elements per hash key after CoGroupByKey, one element 
would be transformed dict and other will untransformed dict. 
   
   each element in the dict should consist of list of length 1. I changed the 
condition a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to