AnandInguva commented on code in PR #29609:
URL: https://github.com/apache/beam/pull/29609#discussion_r1414787307


##########
sdks/python/container/run_generate_requirements.sh:
##########
@@ -30,6 +30,16 @@
 # You will need Python interpreters for all versions supported by Beam, see:
 # https://s.apache.org/beam-python-dev-wiki
 
+if ! [[ "$(expr substr $(uname -s) 1 5)" == "Linux" ]]; then
+  echo This script needs to be executed in a Linux environment.

Review Comment:
   optional: update wiki page since devs mostly update it on their own systems 
(which is Mac).



##########
.github/workflows/python_dependency_tests.yml:
##########
@@ -38,6 +38,8 @@ jobs:
         uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.params.py_ver }}
+      - name: Install headers required by some python packages

Review Comment:
   we might need to install this in the tox tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to