clmccart commented on code in PR #29592:
URL: https://github.com/apache/beam/pull/29592#discussion_r1416337324
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -287,6 +286,8 @@ public class StreamingDataflowWorker {
// Possibly overridden by streaming engine config.
private int maxWorkItemCommitBytes = Integer.MAX_VALUE;
+ private DataflowExecutionStateSampler sampler =
DataflowExecutionStateSampler.instance();
Review Comment:
3be2aa33f9753b5bad6e50190986ee3a62763967
we're using it as a singleton for the StreamingDataflowWorker but the base
class is not necessarily intended to be a singleton
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
