johnjcasey commented on code in PR #29546:
URL: https://github.com/apache/beam/pull/29546#discussion_r1417451895
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -739,6 +754,9 @@ abstract Builder<K, V> setValueDeserializerProvider(
abstract Builder<K, V> setCheckStopReadingFn(@Nullable
CheckStopReadingFn checkStopReadingFn);
+ abstract Builder<K, V> setBadRecordErrorHandler(
+ @Nullable ErrorHandler<BadRecord, ?> badRecordErrorHandler);
Review Comment:
We will never set it to be null. This is @Nullable to indicate that the
property may not be set, and that is valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
