tvalentyn commented on code in PR #29609: URL: https://github.com/apache/beam/pull/29609#discussion_r1418153553
########## sdks/python/container/run_generate_requirements.sh: ########## @@ -30,14 +30,18 @@ # You will need Python interpreters for all versions supported by Beam, see: # https://s.apache.org/beam-python-dev-wiki -if ! [[ "$(expr substr $(uname -s) 1 5)" == "Linux" ]]; then - echo This script needs to be executed in a Linux environment. - exit 1 -fi - -if ! dpkg -s libsnappy-dev >/dev/null ; then - echo You must install libsnappy-dev to run this script. Run: - echo sudo apt install libsnappy-dev +if [[ "$(expr substr $(uname -s) 1 5)" == "Linux" ]]; then + if ! dpkg -s libsnappy-dev >/dev/null ; then + echo You must install libsnappy-dev to run this script. Run: + echo sudo apt install libsnappy-dev + exit 1 + fi +elif [[ "$(expr substr $(uname -s) 1 6)" == "Darwin" ]]; then + if ! brew list snappy >/dev/null ; then + echo You must install snappy to run this script. Run: + echo brew install snappy Review Comment: thanks, please let me know if you can get it to work. I briefly asked another coworker, seems like it's not enough - maybe restarting shell is required? We also tried setting `CPPFLAGS="-I/usr/local/include -L/usr/local/lib" pip install python-snappy` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
