jrmccluskey commented on code in PR #29585:
URL: https://github.com/apache/beam/pull/29585#discussion_r1419175445
##########
sdks/python/apache_beam/io/requestresponseio.py:
##########
@@ -17,11 +17,24 @@
"""``PTransform`` for reading from and writing to Web APIs."""
import abc
+import concurrent.futures
+import contextlib
+import logging
+import sys
+from typing import Generic
+from typing import Optional
from typing import TypeVar
+import apache_beam as beam
+from apache_beam.pvalue import PCollection
+
RequestT = TypeVar('RequestT')
ResponseT = TypeVar('ResponseT')
+DEFAULT_TIMEOUT = 30 # seconds
Review Comment:
Prefer putting units in the variable name for clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
