AnandInguva commented on code in PR #29720:
URL: https://github.com/apache/beam/pull/29720#discussion_r1424471020
##########
sdks/python/apache_beam/ml/transforms/tft.py:
##########
@@ -196,14 +195,17 @@ def apply_transform(
data = self._split_string_with_delimiter(
data, self.split_string_by_delimiter)
+ vocab_filename = self._vocab_filename
+ if vocab_filename:
Review Comment:
I think if None is provided, a filename will be chosen from the current
scope and counter (if there are multiple similar files) is attached to it by tft
For example, for the value None - I see
`['vocab_compute_and_apply_vocabulary_vocabulary',
'vocab_compute_and_apply_vocabulary_1_vocabulary']` as the vocab files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
