Abacn commented on issue #29684:
URL: https://github.com/apache/beam/issues/29684#issuecomment-1854159824

   > Is there a command to reproduce this locally?
   > 
   > I'm not seeing how #29639 is related, but the implementation of 
`FixedPrecisionDecimalLogicalType` does look wrong as it claims the 
`representation_type` is `DecimalLogicalType` but `to_representation_type` and 
`to_language_type` convert to and from `bytes`.
   
   `DecimalLogicalType` and `FixedPrecisionDecimalLogicalType` correspond to 
`DECIMAL` premitive type  and decimal logical type in Java SDK. The portability 
framework excluded `DATETIME` and `DECIMAL` from primitive but they remain in 
Java SDK caused problems as the encoded form of them cannot be decoded using 
portable primitive types (representation_type) and need to special treatments.
   
   I added this as a release blocker as it breaks xlang jdbcio


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to