lostluck commented on code in PR #29761:
URL: https://github.com/apache/beam/pull/29761#discussion_r1425903296
##########
sdks/go/pkg/beam/core/runtime/harness/harness.go:
##########
@@ -662,7 +662,7 @@ func (c *control) handleInstruction(ctx context.Context,
req *fnpb.InstructionRe
},
},
}
- case req.GetSampleData() != nil:
+ case req.GetSampleData() != nil && c.dataSampler != nil:
Review Comment:
Basically, yes, Dataflow is incorrect to be sending these requests, however,
the SDK shouldn't send responses that might cause the job to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
