damccorm commented on PR #29217:
URL: https://github.com/apache/beam/pull/29217#issuecomment-1856588042

   Are there actually other tests in 
https://github.com/apache/beam/tree/3f434f07053d5a73be202cb6d7d70abca200f463/sdks/python/apache_beam/runners/interactive/testing
   
   I ask for 2 reasons:
   1) I'm hesitant to remove our primary source of testing of this code if it 
is just this
   2) If they are and we decide to remove this, should we just remove the whole 
folder?
   
   > @damccorm These flakes block notebooks release and perform no real testing 
of the code itself. They essentially test the fonts and formatting of the 
output of the notebook cells
   
   That is testing something, even if its not the most effective test for that. 
Do we understand why they're flaky? Is it something that could be fixed? cc/ 
@KevinGG who may have thoughts here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to