lostluck commented on PR #29804: URL: https://github.com/apache/beam/pull/29804#issuecomment-1861607179
It is an odd pattern that at present: * setup passes down a nil logger, * then we manually re-build/wrap with buffered loggers wherever we actually do log something. I'd expect us to pass around the buffered logger type from the top, instead of arbitrarily trying to re-construct it. Stuff to clean up when it's not a release blocker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
