VardhanThigle commented on code in PR #29820:
URL: https://github.com/apache/beam/pull/29820#discussion_r1432424914


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########


Review Comment:
   Given that the getOrCreate/close are serialised now, would it make sense to 
make the refcounts non-atomic and (possibly) members of `SpannerAccessror` 
Class? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to