Tejasker commented on issue #29819:
URL: https://github.com/apache/beam/issues/29819#issuecomment-1865671194
Hii @jrmccluskey, I have read the above issue which needs slight
modification in terms of using the logger ie rather than wrapping it in the
buffer logger we can directly pass the bufferLogger which will be created
outside the function and utilised as one of the parameter for `func
installSetupPackages` as required &
I am thinking of the modified function signature as like this one
`func installSetupPackages(ctx context.Context, bufLogger
*tools.BufferedLogger, files []string, workDir string, requirementsFiles
[]string)`
`error {
bufLogger.Printf(ctx, "Installing setup packages ...")// rest of the code
}`
I am assuming it would work. if this approach seems good to you then I can
raise a PR for this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
