liferoad commented on PR #26059: URL: https://github.com/apache/beam/pull/26059#issuecomment-1866858409
> @liferoad FYI you should be able to use a microbenchmark (https://github.com/apache/beam/tree/master/sdks/python/apache_beam/tools) to craft a test to check performance impact of this change. Thanks for letting me know that tool exists. UnionCoder essentially calls the corresponding coder. I checked `UnionCoder[ListCoder[VarIntCoder], ListCoder[StrUtf8Coder]]` vs `ListCoder[VarIntCoder]` on 1000 int elements, UnionCoder is 10 times slower than ListCoder. However, UnionCoder just calls ListCoder. So the slowness is caused by the actual coder tag that is encoded when using UnionCoder, which is somewhat expected when using Union. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
