sjmittal commented on PR #28763:
URL: https://github.com/apache/beam/pull/28763#issuecomment-1868761331
> We need to add tests to this change
I have updated the test cases to
`org.apache.beam.sdk.io.aws2.kinesis.WatermarkPolicyTest`.
The essence of this PR is to get the current timestamp of the stream from
the record if custom watermark policy is set for it, otherwise if falls back to
the arrival time policy.
Hence I have updated the test cases for above class.
In other test classes where we test the Kinesis reader or shard subscribers
the setup itself of these test cases assumes arrival time policy hence there
are no changes to these test classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
