dermasmid opened a new pull request, #29889: URL: https://github.com/apache/beam/pull/29889
The Typescript SDK has not gotten any meaningful updates for a long time, and while trying to use it, i ran into a lot of issues. So after making some fixes for our project im putting some of those changes in this PR, and i'd love to go over them with the team. Here's a summary of the changes: - switch out [ttypescript](https://github.com/cevek/ttypescript?tab=readme-ov-file#deprecation-notice) for [ts-patch](https://github.com/nonara/ts-patch) - use forked package for `serialize-closures` and `ts-closure-transform` as the current version does not support typescript `5.x`, here's the upstream pr https://github.com/nokia/ts-serialize-closures/pull/16/files , for now im hosting it from [here](https://github.com/Triple-Whale/ts-serialize-closures) i did not get the tests to pass after my changes, might need some additional work - added some ts-ignores cuz it would not compile otherwise, i'd love to get help on those - `writeToPubSub` did not work with out `withName` so i added it ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
