damccorm commented on code in PR #29894:
URL: https://github.com/apache/beam/pull/29894#discussion_r1439875874
##########
sdks/java/extensions/sql/build.gradle:
##########
@@ -240,6 +240,12 @@ task integrationTest(type: Test) {
useJUnit { }
}
+task preCommit {
Review Comment:
I think we need something like
https://github.com/apache/beam/blob/6751a1737c19d7022c30e850a718e73cd1909e30/build.gradle.kts#L731
here
##########
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/EmbeddedSdkHarness.java:
##########
@@ -37,15 +37,18 @@
import org.apache.beam.sdk.fn.stream.OutboundObserverFactory;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
import
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import org.junit.Rule;
import org.junit.rules.ExternalResource;
import org.junit.rules.TestRule;
+import org.junit.rules.Timeout;
/**
* A {@link TestRule} which creates a {@link FnHarness} in a thread, services
required for that
* {@link FnHarness} to properly execute, and provides access to the
associated client and harness
* during test execution.
*/
public class EmbeddedSdkHarness extends ExternalResource implements TestRule {
+ @Rule public transient Timeout globalTimeout = Timeout.seconds(600);
Review Comment:
Rather than adding this everywhere, can we do this in a more targeted way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
