robinyqiu commented on a change in pull request #12493:
URL: https://github.com/apache/beam/pull/12493#discussion_r470902732
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java
##########
@@ -232,7 +233,11 @@ private Schema getKeySchema(Schema inputSchema,
List<Integer> keys) {
upstream
.apply(
"assignEventTimestamp",
- WithTimestamps.<Row>of(row ->
row.getDateTime(windowFieldIndex).toInstant())
+ WithTimestamps.<Row>of(
+ row ->
+ Instant.ofEpochMilli(
Review comment:
We plan to support windowing only up to millisecond precision, and the
timestamp here seems only used by windowing. So I guess it is fine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
