TheNeuralBit commented on a change in pull request #12341:
URL: https://github.com/apache/beam/pull/12341#discussion_r470903947
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableProviderWrapper.java
##########
@@ -80,7 +80,7 @@ public BeamSqlTable buildBeamSqlTable(Table tableDefinition) {
}
}
- private BeamTableStatistics getTableStatistics(PipelineOptions options) {
+ public BeamTableStatistics getTableStatistics(PipelineOptions options,
SchemaIO schemaIO) {
Review comment:
nit: I think this just needs to be protected so that implementors can
override
```suggestion
protected BeamTableStatistics getTableStatistics(PipelineOptions options,
SchemaIO schemaIO) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
