Abacn commented on code in PR #29923:
URL: https://github.com/apache/beam/pull/29923#discussion_r1442268989
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java:
##########
@@ -299,55 +324,37 @@ public void readAndValidateRows(BigQueryIOJsonOptions
options) {
return;
}
+ final boolean unescape = options.getWriteMethod() ==
Write.Method.FILE_LOADS;
+
// Testing countries (straight json)
PCollection<KV<String, String>> countries =
jsonRows.apply(
"Convert countries to KV JSON Strings", ParDo.of(new
CountryToKVJsonString()));
- PAssert.that(countries).satisfies(new
CompareJsonStrings(getTestData("countries")));
+ PAssert.that(countries).satisfies(new
CompareJsonStrings(getTestData("countries"), unescape));
// Testing stats (json in struct)
PCollection<KV<String, String>> stats =
jsonRows.apply("Convert stats to KV JSON Strings", ParDo.of(new
StatsToKVJsonString()));
- PAssert.that(stats).satisfies(new
CompareJsonStrings(getTestData("stats")));
+ PAssert.that(stats).satisfies(new CompareJsonStrings(getTestData("stats"),
unescape));
// Testing cities (json in array of structs)
PCollection<KV<String, String>> cities =
jsonRows.apply("Convert cities to KV JSON Strings", ParDo.of(new
CitiesToKVJsonString()));
- PAssert.that(cities).satisfies(new
CompareJsonStrings(getTestData("cities")));
+ PAssert.that(cities).satisfies(new
CompareJsonStrings(getTestData("cities"), unescape));
// Testing landmarks (json in array)
PCollection<KV<String, String>> landmarks =
jsonRows.apply(
"Convert landmarks to KV JSON Strings", ParDo.of(new
LandmarksToKVJsonString()));
- PAssert.that(landmarks).satisfies(new
CompareJsonStrings(getTestData("landmarks")));
+ PAssert.that(landmarks).satisfies(new
CompareJsonStrings(getTestData("landmarks"), unescape));
p.run().waitUntilFinish();
}
- @Test
Review Comment:
The write tests also read from bigquery table for validation with pipelines,
with exactly same pipelines of the read test. So I have consolidated these two
read tests into writeandread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
