damccorm commented on PR #29835: URL: https://github.com/apache/beam/pull/29835#issuecomment-1883671343
> > Will be curious anyone else's thoughts. > > As I understand it, this PR is fine - from a code perspective. BUT, introduces an issue due to some of our testing infrastructure. Not that a test 'fails' but rather a limitation in something we rely on. > > I'm inclined to merge the PR, and then address the limitations in the testing infra afterwards [ if it were to persist ]. Thoughts? > > I agree with this. > > @damccorm do you have any reservations on merging? Where is the failed check? If the test infra is flaky then I agree we shouldn't block on it. If we are turning a meaningful suite permared then I think we should address that before proceeding. Looking at the current pr, I only see the [failing Kafka check](https://github.com/apache/beam/actions/runs/7279070077/job/20128051261) which looks like it is running into a timeout (maybe its stuck)? We likely should not ignore that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
