arvindram03 commented on code in PR #29882:
URL: https://github.com/apache/beam/pull/29882#discussion_r1446550115
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateTracker.java:
##########
@@ -335,6 +375,12 @@ protected void takeSampleOnce(long millisSinceLastSample) {
transitionsAtLastSample = transitionsAtThisSample;
}
updateMillisSinceLastTransition(millisSinceLastSample, state);
+ updateMillisSinceBundleStart(millisSinceLastSample);
+ }
+
+ @SuppressWarnings("NonAtomicVolatileUpdate")
+ private void updateMillisSinceBundleStart(long millisSinceLastSample) {
+ millisSinceBundleStart += millisSinceLastSample;
Review Comment:
I wanted to avoid the log construction which is going to log all the step
name and processing times during every sample taken(very very high frequency
compared to once in 20 mins when we are going to log). Hence, kept the check in
DataflowExecutionStateTracker. I m open to design suggestions to implement this
without constructing the log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
