dermasmid commented on code in PR #29889:
URL: https://github.com/apache/beam/pull/29889#discussion_r1447008150
##########
sdks/typescript/src/apache_beam/io/pubsub.ts:
##########
@@ -121,9 +121,13 @@ function writeToPubSubRaw(
export function writeToPubSub(topic: string, options: WriteOptions = {}) {
return async function writeToPubSub(dataPColl: beam.PCollection<Uint8Array>)
{
- return dataPColl //
- .map((data) =>
- PubSub.protos.google.pubsub.v1.PubsubMessage.encode({ data }).finish(),
+ return dataPColl
+ .map(
+ withName("writeToPubSubEncode", (data) =>
Review Comment:
@robertwb what is the right name to put here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
