robertwb commented on code in PR #29903: URL: https://github.com/apache/beam/pull/29903#discussion_r1447748317
########## sdks/typescript/build.sh: ########## @@ -22,9 +22,6 @@ set -e -# Make the packaging version available to the code. -echo "export const version = \"$npm_package_version\";" > src/apache_beam/version.ts - # Using npx to execute ttsc from the local node_modules environment. npx ttsc -p . Review Comment: Now that we're down to a single command, how about removing build.sh and just putting this `ttsc` call in package.json directly? ########## sdks/typescript/build.sh: ########## @@ -22,9 +22,6 @@ set -e -# Make the packaging version available to the code. Review Comment: Thanks! I couldn't figure out how to do this myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
