sjvanrossum commented on PR #29689: URL: https://github.com/apache/beam/pull/29689#issuecomment-1894636972
@damondouglas Thanks for reviewing this. I haven't had the time yet to to run Nexmark to compare the existing implementation against this implementation using somewhat realistic uses of this code. I'll be able to get that going over the weekend with results early next week. Might be worth holding off a merge until then to make sure this isn't just performing well on synthetic benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
