robertwb commented on code in PR #30013:
URL: https://github.com/apache/beam/pull/30013#discussion_r1454166107
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -139,8 +139,11 @@
mappings:
'ReadFromCsv':
path: 'path'
+ delimiter: 'delimiter'
+ comment: 'comment'
Review Comment:
So, now that I had a chance to actually look at this, it is WAI.
The Python Reader explicitly subsets (via the renaming transform) to comment
and delimiter, while the writer supports delimiter (a comment marker specifying
lines to ignore doesn't makes sense for a writer).
There is no Java CSV reader. The writer supports a delimiter (but, as with
Python, no need for comment). These are read directly from the provided
transform config schema at discovery time.
Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
