chamikaramj commented on code in PR #29834:
URL: https://github.com/apache/beam/pull/29834#discussion_r1458007522
##########
sdks/python/apache_beam/transforms/external_schematransform_provider_test.py:
##########
@@ -135,6 +152,285 @@ def test_run_generate_sequence(self):
assert_that(numbers, equal_to([i for i in range(10)]))
[email protected]_io_java_expansion_service
[email protected](
+ os.environ.get('EXPANSION_PORT'),
+ "EXPANSION_PORT environment var is not provided.")
[email protected](
Review Comment:
Should we change this and above from skips to assertions (so that tests fail
if not set) ?
Otherwise it will be way too easy to accidentally disable these critical
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
