lazarillo commented on issue #29440: URL: https://github.com/apache/beam/issues/29440#issuecomment-1900542855
> +1 on adding docs, I agree this could be clearer. OK, I'll try to work on it this weekend. > > context managers should not be used for streaming > > This isn't quite right; context managers shouldn't be used for pipelines that will never terminate. It is possible for streaming pipelines to be launched and still eventually finish (either because they were written in a way where the watermark _can_ advance to the end of the global window or because a user cancels them). > > > if you would like me to work on documentation stating that context managers should not be used for streaming, I can do that. I would just like some promise / confidence that the PR I create would be merged in (assuming it's good). > > Sure, always happy to review a doc improvement Please help me understand this a bit more, so that I can write the doc better. I don't understand this case where a watermark can advance to the end of the global window. Regardless, I will stress the fact that it will "hang" and not release the job, which might be fine for some cases, but would not be good for a CI/CD pipeline to launch a job. I'll also look through the context manager a bit more, to better understand what it is doing and what it is not doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
