kennknowles commented on code in PR #30049:
URL: https://github.com/apache/beam/pull/30049#discussion_r1459377380
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reshuffle.java:
##########
@@ -44,18 +44,18 @@
*
* <p>A {@link PTransform} that returns a {@link PCollection} equivalent to
its input but
* operationally provides some of the side effects of a {@link GroupByKey}, in
particular
- * checkpointing, and preventing fusion of the surrounding transforms.
+ * redistribution of elements between workers, checkpointing, and preventing
fusion of the
+ * surrounding transforms. Some of these side effects (e.g. checkpointing) are
not portable and will
+ * not occur on workers that don't have these properties when performing a
{@link GroupByKey}.
Review Comment:
s/workers/runners.
Additionally, these operational effects are not guaranteed even on runners
where GroupByKey does have these side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
