damccorm commented on code in PR #30051:
URL: https://github.com/apache/beam/pull/30051#discussion_r1459712497
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -574,6 +574,10 @@ class BeamModulePlugin implements Plugin<Project> {
return project.containerArchitectures().collect { arch -> "linux/" +
arch }
}
+ project.ext.useBuildx = {
+ return project.containerArchitectures() != [project.nativeArchitecture()]
Review Comment:
Really, we just need to use buildx any time we use more than one
architecture. So we should actually probably just gate this on the length of
`containerArchitectures`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]