bfcrampton commented on PR #29999: URL: https://github.com/apache/beam/pull/29999#issuecomment-1905023000
Thanks for the review! Addressed the comments. On #3 I decided to make everything case insensitive as well as support specifying `cuda` or `CUDA` directly. This is a minor nit that I have to workaround when using this library, everywhere else a `device` would be either `cpu`, `cuda`, or `mps`. Lmk what you think, happy to just leave the case insensitivity part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
