TobKed commented on a change in pull request #12541:
URL: https://github.com/apache/beam/pull/12541#discussion_r471498608



##########
File path: CI.md
##########
@@ -75,8 +75,27 @@ run categories. Here is a summary of the run categories with 
regards of the jobs
 Those jobs often have matrix run strategy which runs several different 
variations of the jobs
 (with different platform type / Python version to run for example)
 
+### Google Cloud Platform Credentials
+
+Some of the jobs require variables stored as a [GitHub 
Secrets](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets)
+to perform operations on Google Cloud Platform. Currently these jobs are 
limited to Apache repository only.

Review comment:
       Yes, if variables are set workflow can be fully tested on the fork. It 
will be much more easier thanks to manual trigger by `workflow_dispatch` event 
which provide button to do this. Sentence `Currently these jobs are limited to 
Apache repository only` is not valid since GCP variables check was introduced. 
I missed that. I will create separate PR for this fix. Thanks for pointing this 
out.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to