lukecwik commented on a change in pull request #12599:
URL: https://github.com/apache/beam/pull/12599#discussion_r471639540



##########
File path: 
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDoNaiveBounded.java
##########
@@ -106,8 +106,8 @@
     @Override
     public PCollectionTuple expand(PCollection<KV<byte[], KV<InputT, 
RestrictionT>>> input) {
       return input
-          .apply("Drop key", Values.create())
           .apply("Reshuffle", Reshuffle.of())
+          .apply("Drop key", Values.create())

Review comment:
       The `input` PCollection passed in is already using random keys.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to