mutianf commented on code in PR #30147:
URL: https://github.com/apache/beam/pull/30147#discussion_r1473246718
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -395,7 +395,14 @@ public void onResponse(Row response) {
@Override
public void onError(Throwable t) {
- future.setException(t);
+ if (byteLimitReached) {
+ // When the byte limit is reached we cancel the stream in
onResponse.
+ // In this case we don't want to fail the request with
cancellation
+ // exception. Instead, we construct the next request.
+ onComplete();
Review Comment:
I don't think that could happen. If there's a bad response, the exception
will be thrown before onResponse() is called which means it'll happen before
byteLimit is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
