JayajP commented on code in PR #30118:
URL: https://github.com/apache/beam/pull/30118#discussion_r1473439500
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/MetricsToPerStepNamespaceMetricsConverter.java:
##########
@@ -52,16 +52,16 @@ private static Optional<MetricValue>
convertCounterToMetricValue(
return Optional.empty();
}
- BigQuerySinkMetrics.ParsedMetricName labeledName =
+ Optional<BigQuerySinkMetrics.ParsedMetricName> labeledName =
Review Comment:
Done.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java:
##########
@@ -40,10 +41,10 @@
*
* <p>In general metrics be in the namespace 'BigQuerySink' and have their
name formatted as:
*
- *
<p>'{baseName}-{metricLabelKey1}:{metricLabelVal1};...{metricLabelKeyN}:{metricLabelValN};'
+ *
<p>'{baseName}*{metricLabelKey1}:{metricLabelVal1};...{metricLabelKeyN}:{metricLabelValN};'
*/
public class BigQuerySinkMetrics {
- private static Boolean supportMetricsDeletion = false;
+ private static boolean supportMetricsDeletion = false;
Review Comment:
This value is mutable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
