lukecwik commented on a change in pull request #12594:
URL: https://github.com/apache/beam/pull/12594#discussion_r471632995
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDoNaiveBounded.java
##########
@@ -106,8 +106,8 @@
@Override
public PCollectionTuple expand(PCollection<KV<byte[], KV<InputT,
RestrictionT>>> input) {
return input
- .apply("Drop key", Values.create())
.apply("Reshuffle", Reshuffle.of())
Review comment:
This change was necessary to make the key coder deterministic. Note that
the PCollection passed in is already using random keys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
