Polber commented on code in PR #30186:
URL: https://github.com/apache/beam/pull/30186#discussion_r1474750740
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -383,13 +383,6 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
Boolean autoSharding = configuration.getAutoSharding();
int numStreams = configuration.getNumStreams() == null ? 0 :
configuration.getNumStreams();
- // TODO(https://github.com/apache/beam/issues/30058): remove once
Dataflow supports multiple
- // DoFn's per fused step.
- if (numStreams < 1) {
- throw new IllegalStateException(
- "numStreams must be set to a positive integer when input data is
unbounded.");
- }
Review Comment:
Both really good points. I just wanted there to be a way to fail earlier
(unfortunately xlang doesn't pick up runner implementation from what I could
see to check dataflow specifically, but sounds like that isn't feasible. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
