arunpandianp commented on code in PR #30194:
URL: https://github.com/apache/beam/pull/30194#discussion_r1475797590
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java:
##########
@@ -260,6 +260,12 @@ public Dataflow create(PipelineOptions options) {
void setstreamingSideInputCacheExpirationMillis(Integer value);
+ @Description("Number of commit threads used to commit items to streaming
engine.")
+ @Default.Integer(1)
+ Integer getWindmillServiceCommitThreads();
Review Comment:
Added testBasicWithMultipleCommitThreads to StreamingDataflowWorkerTest
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -719,8 +726,10 @@ public void stop() {
dispatchThread.join();
// We need to interrupt the commitThread in case it is blocking on
pulling
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
