kennknowles commented on PR #30193: URL: https://github.com/apache/beam/pull/30193#issuecomment-1923661618
R: @chamikaramj Need one more little fix - this successfully isolated the change that caused all the mocking in `DataflowWorkUnitClientTest` to fail. My take on that test is that it has so much mocking it basically tests nothing, so I had just deleted it in my other PR. But with this level of isolation maybe I'll see if I can figure out what is going on. I don't think it has anything to do with functionality, and is just mocking always being a bad idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
