riteshghorse commented on code in PR #30178:
URL: https://github.com/apache/beam/pull/30178#discussion_r1476245730


##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -70,6 +71,13 @@ func RunPipeline(j *jobservices.Job) {
                j.Failed(err)
                return
        }

Review Comment:
   more of an understanding question: in case of a `Cancel`, the err here will 
be nil which is returned from 
[here](https://github.com/apache/beam/pull/30178/files#diff-a9df335416772bd68225ef5d43f089bd6f0eb678f5472330168051d9bec3df1eR282)?
 and then handled below 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to