Abacn commented on code in PR #30168:
URL: https://github.com/apache/beam/pull/30168#discussion_r1476760468
##########
.test-infra/tools/stale_dataflow_prebuilt_image_cleaner.sh:
##########
@@ -89,24 +98,24 @@ for image_name in ${IMAGE_NAMES[@]}; do
MANIFEST=$(docker manifest inspect ${image_name}@"${current}" ||
echo "")
if [ -z "$MANIFEST" ]; then
# Sometimes "no such manifest" seen. Skip current if command hit
error
- FAILED_INSPECT+=" $current"
+ FAILED_IMAGES+=" $current"
continue
fi
SHOULD_DELETE=0
DIGEST=$(echo $MANIFEST | jq -r '.manifests[0].digest')
if [ "$DIGEST" != "null" ]; then
SHOULD_DELETE=1
- for i in ${STALE_IMAGES_CURRENT[@]}; do
- if [ "$i" = "$DIGEST" ]; then
+ for (( j_stale_images_current=0;
j_stale_images_current<${#STALE_IMAGES_CURRENT[@]} ; j_stale_images_current+=2
)) ; do
Review Comment:
Now STALE_IMAGES_CURRENT is of format (digest creation_year digest
creation_year ...) so we do not need to make a second docker API call (`docker
inspect ...`) for the images of nonzero length (actual image)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
