shunping commented on PR #30205: URL: https://github.com/apache/beam/pull/30205#issuecomment-1927156993
> Should [`.get_bucket` in `self._gcs_object`](https://github.com/apache/beam/blob/d7f7b43248b370188df6775b604b70fd63512713/sdks/python/apache_beam/io/gcp/gcsio.py#L418) also be replaced with `.bucket`? > > It seems like [`bucket.get_blob`](https://github.com/googleapis/python-storage/blob/a0416a24c6194850177082bec023346b8acd17a6/google/cloud/storage/bucket.py#L1176-L1281) already makes a HTTP request to check whether the blob exists, or am I missing something? I checked the code, it should be fine to replace the `get_bucket()` with `bucket()` within `_gcs_object()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
