lostluck commented on code in PR #30157:
URL: https://github.com/apache/beam/pull/30157#discussion_r1481653458
##########
model/job-management/src/main/proto/org/apache/beam/model/job_management/v1/beam_job_api.proto:
##########
@@ -56,6 +56,9 @@ service JobService {
// Cancel the job
rpc Cancel (CancelJobRequest) returns (CancelJobResponse);
+ // Drain the job
+ rpc Drain (DrainJobRequest) returns (DrainJobResponse);
Review Comment:
Not at this point, as this change doesn't affect users until we hook things
up.
If an SDK hooks it up so that dataflow drain is adapted through job
management, that should go in Changes.md. once Damon adds drain to Prism, that
should be added to changes.md.
There's an argument on the other side though about it being mentioned there
to help spur that subsequent work, but I think that's outside what Changes.md
is for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
