kennknowles commented on code in PR #30252:
URL: https://github.com/apache/beam/pull/30252#discussion_r1481980495
##########
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java:
##########
@@ -137,402 +132,365 @@ public interface ExpansionServiceRegistrar {
public static class ExternalTransformRegistrarLoader
implements ExpansionService.ExpansionServiceRegistrar {
- private static final SchemaRegistry SCHEMA_REGISTRY =
SchemaRegistry.createDefault();
-
@Override
- public Map<String, ExpansionService.TransformProvider> knownTransforms() {
- ImmutableMap.Builder<String, ExpansionService.TransformProvider> builder
=
Review Comment:
I was getting duplicate key errors from this builder, which is not built
until after everything. So this is actually the thing that specifically I
needed to refactor to get more messages in the middle. (and I did figure out it
was a splittable keyed pardo registration or something like that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
